Repository navigation
ast: mark ast.Num etc. as deprecated - #10994
Merged
Merged
Conversation
PEP 702 was just accepted. As the decorator should simply be ignored by type checkers that do not support it yet, I don't see anything blocking us from using it now. This is the first simple-looking deprecation in https://docs.python.org/3.12/whatsnew/3.12.html#deprecated I'll see what CI has to say here before looking at others.
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Nov 8, 2023
AlexWaygood
approved these changes
Nov 8, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Nice, those are very useful error messages emitted by pyright!
AlexWaygood
reviewed
Nov 8, 2023
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Waygood <[email protected]>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 702 was just accepted. As the decorator should simply be ignored
by type checkers that do not support it yet, I don't see anything
blocking us from using it now.
This is the first simple-looking deprecation in
https://docs.python.org/3.12/whatsnew/3.12.html#deprecated
I'll see what CI has to say here before looking at others.