Skip to content

Stubs for PyMySQL #631

Closed
Closed

Description

@jhagerer

Hi together,

I just began generating stubs for PyMySQL. I auto-generated the stuff via mypy/stubgen.py based on Python 3.5 and afterwards modified the .pyi files manually so that mypy doesn't return errors when type checking my small project.

Since I am new to all this I would be glad to hear some feedback about the work and if there's an option to get this included in future versions of typeshed. Moreover I invite everybody to help me to improve the stubs, especially since it's my first contribution.

Here's the repo link:
https://github.com/ghagerer/pymysql_stubs

Activity

  1. gvanrossum commented on Oct 25, 2016

    @gvanrossum
    Member

    To start, we'd like to hear from the original project's authors. Read here: https://github.com/python/typeshed#third_party

  2. jhagerer commented on Oct 26, 2016

    @jhagerer
    Author

    I got a permission from here. So what's the next step then?

  3. gvanrossum commented on Oct 26, 2016

    @gvanrossum
    Member

    Please make a PR for the typeshed repo that adds your stubs to the third_party tree. Depending on whether your stubs are for Python 2, Python 3, or both, they should go into third_party/2.7, third_party/3, or third_party/2and3. Make sure your PR states that it fixes this issue.

  4. added a commit that references this issue on Nov 1, 2016
  5. JelleZijlstra commented on Jul 2, 2017

    @JelleZijlstra
    Member

    third_party/2and3/pymysql exists now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions