Skip to content

requests.packages.urllib3.exceptions stubs are incomplete (e.g. SNIMissingWarning is missing) #6054

Closed
#6865
Closed
requests.packages.urllib3.exceptions stubs are incomplete (e.g. SNIMissingWarning is missing)#6054
#6865
Labels
stubs: incompleteAnnotations or sub-modules missing from an existing package or module

Description

@rogalski
rogalski
opened on Sep 20, 2021

from requests.packages.urllib3.exceptions import SNIMissingWarning is valid import.
It's part of module public API: https://github.com/urllib3/urllib3/blob/d8eabf304190c62766e05c79ef44be7ff94cfbcb/src/urllib3/exceptions.py#L260

Yet mypy complains: error: Module "requests.packages.urllib3.exceptions" has no attribute "SNIMissingWarning" [attr-defined]

Activity

  1. srittau
    added
    stubs: incompleteAnnotations or sub-modules missing from an existing package or module
    on Sep 20, 2021

  2. srittau commented on Sep 20, 2021

    @srittau
    srittau
    on Sep 20, 2021
    Collaborator

    Any contributions are welcome!

  3. srittau commented on Jan 8, 2022

    @srittau
    srittau
    on Jan 8, 2022
    Collaborator

    We have decided to remove the requests.packages.urllib3 sub-package and are instead concentrating on creating proper urllib3 stubs.

  4. srittau
    closed this as completedon Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stubs: incompleteAnnotations or sub-modules missing from an existing package or module

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions