Repository navigation
Missing type annotations for properties on logging.LoggerAdapter #5015
Description
Hi,
LoggerAdapter class have 2 new properties starting from version 3.6*:
manager (getter and setter)
name (getter)
This have no equivalent in typeshed, I'd like to create them. What do you think?
*Unfortunately these properties can't be found on the official cpython docs, however I found the relevant python bug and pr's:
https://bugs.python.org/issue31457
python/cpython@cf2a4f9
python/cpython@fee0475
I opened a docs bug for cpython and plan on making a PR on this front too.
Activity
Akuli commentedon Feb 10, 2021
I believe the typeshed convention is to add attributes like this with a comment
# undocumented. Even pull requests adding_non_publicattributes are accepted when someone needs those non-public attributes.[-]Missing type annotations for properties on logging.LoggerAdapter[/-][+]Missing type annotations for properties on logging.LoggerAdapter #undocumented[/+][-]Missing type annotations for properties on logging.LoggerAdapter #undocumented[/-][+]Missing type annotations for properties on logging.LoggerAdapter # undocumented[/+][-]Missing type annotations for properties on logging.LoggerAdapter # undocumented[/-][+]Missing type annotations for properties on logging.LoggerAdapter[/+]Akuli commentedon May 12, 2021
fixed in #5388