stdlib.3.unitest.mock missing NonCallableMock methods #3842

Activity

1. srittau commented on Mar 12, 2020

   

   srittau

   on Mar 12, 2020

   Collaborator

   More actions

   The probable reason NonCallableMock (and the other mock classes) were defined like this is so that they can be passed in place as any other object without type checkers complaining. I think I remember some discussion about it where it was suggested that the mock classes should derive from Any instead, something like this:

   class NonCallableMock(Base, Any):
       def __getattr__(self, name: str) -> Any: ...
       # other methods go here

   I quickly tried this, and it seems to work fine with mypy. I think this is worth a go.
2. srittau

   added

   size-medium

   on Mar 12, 2020
3. rodrigondec commented on Mar 12, 2020

   

   rodrigondec

   on Mar 12, 2020

   ContributorAuthor

   More actions

   @srittau Assign this to me plz
4. JelleZijlstra

   assigned

   rodrigondec

   on Mar 12, 2020
5. srittau

   closed this as completedin #3846on Mar 20, 2020