Repository navigation
iscoroutinefunction should use TypeIs #15529
Description
One of the things I find myself writing a lot is
if iscoroutinefunction(myfunction):
do_something_with_async(myfunction)
else:
do_something_with_just_sync(myfunction)however the else block doesn't narrow the type to non-awaitable. Shouldn't it? Some of the other is... functions in inspect seem to use TypeIs as well.
Activity
srittau commentedon Mar 20, 2026
I assume changing the return type to
TypeIswas deliberately left out of #11823. Maybe @JelleZijlstra can provide some insight?dchevell commentedon Apr 20, 2026
My understanding is that
TypeIshas no defined behaviour for structural types (i.e.Callable), so making this change in typeshed wouldn’t necessarily guarantee you anything. (Though personally I wish theTypeIsspec would formally supportCallable, but hey)Edit: see https://discuss.python.org/t/specs-clarification-typeis-works-with-all-types-structural-or-nominal/95120
JelleZijlstra commentedon Apr 20, 2026
That is false.
InvincibleRMC commentedon Jun 7, 2026
I have a similar situation as @Redoubts is the solution as simple as making a pr switching from
TypeGuardtoTypeIsforinspect.iscoroutinefunction? I'm not too familiar with their differences.