Repository navigation
runtests.py trips over sqlalchemy #137
Description
Running runtests.py locally using python3 runtests.py, I get:
running mypy --python-version 3.5 # with 250 files
running mypy --python-version 3.4 # with 250 files
running mypy --python-version 3.3 # with 236 files
running mypy --python-version 3.2 # with 235 files
running mypy --python-version 2.7 # with 334 files
third_party/2.7/sqlalchemy/engine/url.pyi:8: error: "module" has no attribute "registry"
third_party/2.7/sqlalchemy/orm/__init__.pyi:6: error: Module has no attribute 'mapper'
third_party/2.7/sqlalchemy/orm/__init__.pyi:7: error: Module has no attribute 'interfaces'
third_party/2.7/sqlalchemy/orm/__init__.pyi:8: error: Module has no attribute 'deprecated_i
nterfaces'
third_party/2.7/sqlalchemy/orm/__init__.pyi:9: error: Module has no attribute 'util'
third_party/2.7/sqlalchemy/orm/__init__.pyi:10: error: Module has no attribute 'properties'
third_party/2.7/sqlalchemy/orm/__init__.pyi:11: error: Module has no attribute 'relationshi
ps'
third_party/2.7/sqlalchemy/orm/__init__.pyi:12: error: Module has no attribute 'descriptor_
props'
third_party/2.7/sqlalchemy/orm/__init__.pyi:14: error: Module has no attribute 'scoping'
third_party/2.7/sqlalchemy/orm/__init__.pyi:15: error: Module has no attribute 'query'
third_party/2.7/sqlalchemy/orm/__init__.pyi:17: error: Module has no attribute 'strategy_op
tions'
third_party/2.7/sqlalchemy/orm/__init__.pyi:46: error: "module" has no attribute "object_se
ssion"
third_party/2.7/sqlalchemy/orm/__init__.pyi:48: error: "module" has no attribute "make_tran
sient"
third_party/2.7/sqlalchemy/orm/__init__.pyi:49: error: "module" has no attribute "make_tran
sient_to_detached"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:12: error: "module" has no attribute "co
mpiler"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:13: error: "module" has no attribute "re
flection"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:14: error: "module" has no attribute "de
fault"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:15: error: "module" has no attribute "to
pological"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:31: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:35: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:39: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:47: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:50: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:54: error: Invalid type "sqlalc[33/9160]
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:62: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:66: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:71: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:75: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:87: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:91: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:97: error: Invalid type "sqlalchemy.dial
ects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:103: error: Invalid type "sqlalchemy.dia
lects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:108: error: Invalid type "sqlalchemy.dia
lects.mysql.base.sqltypes"
third_party/2.7/sqlalchemy/dialects/mysql/base.pyi:113: error: Invalid type "sqlalchemy.dia
lects.mysql.base.sqltypes"
[...]
third_party/2.7/sqlalchemy/dialects/mysql/__init__.pyi:40: error: "module" has no attribute "dialect"
Is sqlalchemy still broken, like #14 seems to imply? How come Travis isn't yelling at us?
Activity
matthiaskramm commentedon Apr 8, 2016
Nm, I found the line
in
.travis.yml.What's our long-term plan with that? Is somebody looking into fixing the sqlalchemy stubs? If not, my vote would be to remove them.
gvanrossum commentedon Apr 9, 2016
Some subset of them actually works. I had hoped that @timabbott (who contributed the bulk) would finish them off, but he's been distracted. Maybe we should just comment out or remove the failing part?
timabbott commentedon Apr 9, 2016
If I recall correctly, I think I fixed the stubs for
sqlalchemy.sql, but the stubs forsqlalchemy.ormare highly incomplete.timabbott commentedon Apr 9, 2016
It's definitely a nontrivial amount of work left to fix the rest of the sqlalchemy stubs.
gvanrossum commentedon Apr 10, 2016
I propose to comment out anything that doesn't compile for now. I can take
care of that.
Backport performance improvements to runtime-checkable protocols (pyt…