Skip to content

Tornado module for Python 2.7 broken locally in tests #114

Closed

Description

@ddfisher

Running with Python 3.5.1 on OS X, I get:

$ python3 runtests.py
running mypy --python-version 3.5 # with 243 files
running mypy --python-version 3.4 # with 243 files
running mypy --python-version 3.3 # with 229 files
running mypy --python-version 3.2 # with 228 files
running mypy --python-version 2.7 # with 330 files
third_party/2.7/sqlalchemy/sql/base.pyi:4: note: In module imported here,
third_party/2.7/sqlalchemy/engine/strategies.pyi:6: note: ... from here:
third_party/2.7/tornado/util.pyi:1: error: Duplicate module named '.util'
--- exit status 1 ---

Activity

  1. gvanrossum commented on Mar 11, 2016

    @gvanrossum
    Member

    You should run it as follows:

    python3 runtests.py -x sqlalchemy
    

    There's still something wrong with the sqlalchemy stubs. Strange though that it also complains about tornado in this case.

  2. ddfisher commented on Mar 12, 2016

    @ddfisher
    ContributorAuthor

    Do you think it's worth putting a script in the repo which runs runtests.py with the same flags as CI? (And then making CI use that script, obviously.)

  3. gvanrossum commented on Mar 12, 2016

    @gvanrossum
    Member

    No, we should fix the sqlalchemy stubs.

    On Fri, Mar 11, 2016 at 4:34 PM, David Fisher [email protected]
    wrote:

    Do you think it's worth putting a script in the repo which runs
    runtests.py with the same flags as CI? (And then making CI use that
    script, obviously.)

    —
    Reply to this email directly or view it on GitHub
    #114 (comment).

    --Guido van Rossum (python.org/~guido)

  4. gvanrossum commented on Apr 21, 2016

    @gvanrossum
    Member

    Done in 4f483dc.

  5. added a commit that references this issue on Jul 5, 2016
    6338be6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions