Skip to content

ArgumentParser.parse_args with Namespace subclass does not work anymore #10400

Closed
Closed
ArgumentParser.parse_args with Namespace subclass does not work anymore#10400
Labels
stubs: false positiveType checkers report false errors

Description

@lkct
lkct
opened on Jul 3, 2023

Ref: microsoft/pylance-release#4569 (comment)

This is introduced in #10307. (cc @qthequartermasterman as the author)

typeshed/stdlib/argparse.pyi

Lines 173 to 178 in 31dca1d

@overload
def parse_args(self, args: Sequence[str] | None = None, namespace: Namespace | None = None) -> Namespace: ... # type: ignore[misc]
@overload
def parse_args(self, args: Sequence[str] | None, namespace: _N) -> _N: ...
@overload
def parse_args(self, *, namespace: _N) -> _N: ...
See More

The first overload now shadows the following. E.g., ArgumentParser().parse_args(namespace=MyNamespace()) should match the third but actually matches the first, which unexpectedly returns Namespace instead of MyNamespace.

Activity

  1. srittau commented on Jul 3, 2023

    @srittau
    srittau
    on Jul 3, 2023
    Collaborator

    See discussion in #10387.

  2. srittau
    added
    stubs: false positiveType checkers report false errors
    on Jul 3, 2023
  3. srittau
    closed this as completedon Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stubs: false positiveType checkers report false errors

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions