Skip to content

[requests] Change urllib3 dependency #10142

Closed

Description

@srittau

As of requests 2.30, the urllib3 dependency is pinned to >=1.21.1,<3, so it works with urllib3 v2, which ships its own type stubs. We should change the dependency from types-urllib3 to urllib3>=2,<3.

Activity

  1. AlexWaygood commented on May 5, 2023

    @AlexWaygood
    Member

    Yup. The reason why that's difficult is that we don't test stubs in isolation when running pyright in CI. It's the same issue I hit in #10090 (comment), and the same issue that @sobolevn hit in #9989 (comment)

  2. AlexWaygood commented on Jul 8, 2023

    @AlexWaygood
    Member

    Can't be done until we do #6898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: deferredIssue or PR deferred until some precondition is fixed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions