Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

The latest version 1.0.4 installation fails under Python 3.4 in Windows #46

Closed

Description

@webknjaz

Activity

  1. emmatyping commented on Jul 15, 2017

    @emmatyping
    Member

    typed_ast only supports Python 3.5+ Windows. See #24 for more about this.

  2. webknjaz commented on Jul 15, 2017

    @webknjaz
    MemberAuthor

    Oh.. Probably it's mypy, which started depending on newer version of typed_ast.

    I think, this case deserves adding some check into setup.py. Any objections?

  3. added a commit that references this issue on Jul 15, 2017
    b177b76
  4. emmatyping commented on Jul 15, 2017

    @emmatyping
    Member

    Do you mean a check in typed_ast or mypy? I think an error message if typed_ast is built on an unsupported platform/python version combination might be a good thing. Ultimately up to @ddfisher.

  5. webknjaz commented on Jul 15, 2017

    @webknjaz
    MemberAuthor

    I meant error message typed_ast, which would look user-friendly and would have a reference to corresponding issue.

  6. emmatyping commented on Jul 16, 2017

    @emmatyping
    Member

    I actually just made a patch which should build typed_ast on VS2010, so it would work with Python 3.4. VS2010 makes some things more complicated so even if my patch is accepted, mypy still wouldn't support 3.4 due to lxml.

  7. webknjaz commented on Jul 16, 2017

    @webknjaz
    MemberAuthor

    Nevermind, I've just disabled installing mypy in non-supported env. Anyway we don't run it in Appveyor.

  8. emmatyping commented on Aug 25, 2017

    @emmatyping
    Member

    Just as follow up, typed_ast (and thus mypy) work on Windows with Python 3.3 and 3.4

  9. webknjaz commented on Aug 25, 2017

    @webknjaz
    MemberAuthor

    Thanks for the info 👍

  10. webknjaz commented on Aug 25, 2017

    @webknjaz
    MemberAuthor

    I should mention that it requires some conditional magic until new mypy version released (ref python/mypy#3802):
    https://github.com/aio-libs/multidict/blob/dd078b2112bf15f0158cf8497c5bdafa7f25912a/requirements/ci.txt#L11-L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions