This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 5, 2023. It is now read-only.
What's the point of inserting a space character in the dump before extra fields? #23
Description
In dump() function, there's the following expression in line 116:
rv += fields and ', ' or ' '
The space character literal at the end of the expression causes the dump of e.g. Pass to be:
Pass( lineno=44, col_offset=4)
Is there a point to this? Or, could it be that this space should be removed, so that the dump is:
Pass(lineno=44, col_offset=4)
?
I've done this in this commit, should I PR? mbdevpl@589d064
Activity
ddfisher commentedon Jan 5, 2017
That's a good question, but you'll have to ask the CPython folks. The
dump()function inast27andast35is exactly the same as the version in the CPythonastlibrary. (See here.)typed_astis intended to behave as similarly as possible toast(aside from type comment-related changes), so I don't want to change this behavior, even though I agree it's a little strange.Import sys in setup.py and fix build for mingw (python#23)