You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Instead of adding a new ast3x module for every new Python version, we're now planning on updating the ast35 module with the Python changes. Accordingly, the ast27 and ast35 modules should probably be renamed to ast2 and ast3, respectively.
Oh, and FWIW my opinion on the matter is to leave the name "ast27", unless GvR is secretly planning to release 2.8 ;) The point of "ast3" is forward-compatibility, not backwards-compatibility, right?
On Feb 22, 2017 4:29 PM, "Łukasz Langa" ***@***.***> wrote:
Oh, and FWIW my opinion on the matter is to leave the name "ast27", unless
GvR is secretly planning to release 2.8 ;) The point of "ast3" is
forward-compatibility, not backwards-compatibility, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMh0WsS7Gs0nKSHjKY-lWCGpNZMjyks5rfO8EgaJpZM4KIR0e>
.
When changing the names of the modules, please consider moving them out the common namespace, i.e. moving them to typed_ast._ast3, typed_ast._ast2. "Polluting" the global namespace is not nice and raises the chances of conflict in the future.
When changing the names of the modules, please consider moving them out the common namespace, i.e. moving them to typed_ast._ast3, typed_ast._ast2. "Polluting" the global namespace is not nice and raises the chances of conflict in the future.
Note that this hasn't happened yet -- IIUC this is asking to rename the extension modules from toplevel _ast27 and _ast3 into the typed_ast namespace. I think that's possible though I don't recall how. It would need a separate issue though.
Activity
ddfisher commentedon Feb 13, 2017
ast35has been renamedast3as part of the Python 3.6 rebuild.gvanrossum commentedon Feb 13, 2017
Let's decide whether we want to rename ast27 -> ast2 as well, or whether we'll stick with that -- in the latter case we can close this issue.
ambv commentedon Feb 23, 2017
FYI, currently the source tarball of 1.0.1 contains both ast2.py and ast27.py which makes the bundled tests fail (there's no _ast2, just _ast27).
ddfisher commentedon Feb 23, 2017
That's unfortunate. Will PyPI let me upload a fixed sdist if I remove the old one?
ambv commentedon Feb 23, 2017
Not a .tar.gz. Fortunately, there's a trick.
ambv commentedon Feb 23, 2017
Oh, and FWIW my opinion on the matter is to leave the name "ast27", unless GvR is secretly planning to release 2.8 ;) The point of "ast3" is forward-compatibility, not backwards-compatibility, right?
gvanrossum commentedon Feb 23, 2017
ddfisher commentedon Feb 24, 2017
@ambv: Fixed using that trick, thanks.
keszybz commentedon Jun 11, 2017
When changing the names of the modules, please consider moving them out the common namespace, i.e. moving them to
typed_ast._ast3,typed_ast._ast2. "Polluting" the global namespace is not nice and raises the chances of conflict in the future.msullivan commentedon Jan 23, 2019
This happened a while ago
gvanrossum commentedon Jan 23, 2019
Note that this hasn't happened yet -- IIUC this is asking to rename the extension modules from toplevel
_ast27and_ast3into thetyped_astnamespace. I think that's possible though I don't recall how. It would need a separate issue though.