Repository navigation
Conversation
Original discussion: https://twitter.com/llanga/status/1006974601723723776
willingc
approved these changes
Jun 13, 2018
| ``pass``. | ||
|
|
||
| Do not use ``...`` or ``None`` for this purpose. The former suggests | ||
| "details supressed" instead of "there is nothing there". The latter |
Contributor
There was a problem hiding this comment.
typo: suppressed
| Empty blocks | ||
| ------------ | ||
|
|
||
| Use ``pass`` to denote a block is intentionally empty. In empty |
Contributor
There was a problem hiding this comment.
...block which is intentionally left empty.
Member
|
I still don't think this needs to make it into PEP 8 -- I don't think I've ever seen a debate about this or code doing it wrong until Łukasz brought it up on Twitter. We should exercise restraint when adding to PEP 8 -- it's already getting long, and there are more important things that it's not even mentioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original discussion: https://twitter.com/llanga/status/1006974601723723776