Repository navigation
Add test case for disable_error_code config file option - #9538
Merged
Merged
Conversation
Add disable/enable error code opt to config_types
Member
|
Shouldn't this all be one PR? |
Contributor
Author
Yes, this one is the one to keep. |
Member
|
@hauntsaninja can you help?
On Mon, Oct 5, 2020 at 12:24 Aristotelis Mikropoulos < ***@***.***> wrote:
Shouldn't this all be one PR?
Indeed, but I am not sure the test case I added is valid. The previous PR
is correct though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9538 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWCWMRTIBK5VZLZUDTKMZDSJIMP5ANCNFSM4SFB6UQA>
.
--
--Guido (mobile)
|
Contributor
Author
|
The tests passed, so this one seems good to be kept. |
hauntsaninja
approved these changes
Oct 5, 2020
hauntsaninja
left a comment
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me, thanks again!
Contributor
Author
|
No problem, glad to help. |
JukkaL
pushed a commit
that referenced
this pull request
Oct 8, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.