Repository navigation
Conversation
hauntsaninja
reviewed
Oct 5, 2020
hauntsaninja
left a comment
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm, thanks for reporting and fixing! If you wanted to add a test, test-data/unit/check-flags.test would be the place to do it
Contributor
Author
|
Tried this #9538 without being sure of the exact format of the test case fixtures, though. |
Collaborator
|
Closing in favour of #9538 then :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
disable_error_codeandenable_error_codeconfig file options were being cast to list, as they were notincluded in the config_types dict in config_parser.py.