Skip to content

Add cwd argument to Python 3 stubs for subprocess calls. - #889

Merged
JukkaL merged 1 commit into
python:masterfrom
Vlad-Shcherbina:subprocess_cwd
Oct 7, 2015
Merged

JukkaL merged 1 commit into
python:masterfrom
Vlad-Shcherbina:subprocess_cwd

Conversation

@Vlad-Shcherbina

Copy link
Copy Markdown
Contributor

No description provided.

@o11c

o11c commented Oct 2, 2015

Copy link
Copy Markdown
Contributor

Maybe you should check all the functions in that stub take all the possible keyword arguments.

@Vlad-Shcherbina

Copy link
Copy Markdown
Contributor Author

I agree that it's totally worth doing eventually. I myself intend to do it, even (no promises though). But I would prefer to do it in a separate PR, unless the owner insists. For now I'm just testing the waters, how contribution to this project works (for instance, whether I'll be asked to send this patch to typeshed instead, or I don't know what).

In addition, I'm reasonably confident in this trivial change, while updating all keyword arguments is much more error-prone, as they are scattered across module documentation.

@matthiaskramm

Copy link
Copy Markdown
Contributor

Yes, sending an (additional?) PR to http://github.com/python/typeshed would make a lot of sense.
(Until #884 is merged, all stubs changes should probably happen in both repositories, to keep things in sync)

@JukkaL

JukkaL commented Oct 7, 2015

Copy link
Copy Markdown
Collaborator

Yeah, until we have a complete stub story sending PRs to typeshed as well would be appreciated (but not necessary). Also, it's totally fine to send only small updates or fixes to stubs such as these.

JukkaL added a commit that referenced this pull request Oct 7, 2015
Add `cwd` argument to Python 3 stubs for subprocess calls.
@JukkaL
JukkaL merged commit 874be10 into python:master Oct 7, 2015
@JukkaL

JukkaL commented Oct 7, 2015

Copy link
Copy Markdown
Collaborator

And thanks for the PR!

@matthiaskramm

Copy link
Copy Markdown
Contributor

Applied this change to http://github.com/python/typeshed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants