Repository navigation
mypy: require Python 3.5.3 or greater - #8384
hauntsaninja wants to merge 1 commit into
Conversation
See python#8380 for motivation
|
We could also a) just change the version that runs CI, in which case users with 3.5.1 or 3.5.2 can continue to run mypy, but would run into issues if they attempted to use stubtest (and maybe face regressions in the future), b) skip stubtest tests in CI for all of 3.5 (note at least typeshed will run stubtest with 3.5). |
|
We could drop 3.5.1 support but I dropping 3.5.2 support is a nonstarter. We still (unfortunately) run mypy with 3.5.2 in some places. Ubuntu 16.04.6 has 3.5.2. I don't really mind dropping stubtest support though in 3.5.2? |
|
Hmm okay! If 3.5.2 support is important, then changing what we run in CI isn't great (option a, above). Let me try harder to workaround the Python bug (I would have done that first, but I can't seem to build a working version of 3.5.1 or 3.5.2... which leaves test-debugging through Travis as my option). |
2 participants
See #8380 for motivation, we run into some issue with the version of typing.py in 3.5.1 (same as in dropbox/sqlalchemy-stubs#63). It's also hard to find workarounds, because I can't get a working version of that Python going.
3.5.1 is over four years old, and EOL for 3.5 is in seven months.
Obviously understand if we can't/don't want to merge this.