Skip to content

Include assets in the source tarball. - #743

Closed
fladi wants to merge 1 commit into
python:masterfrom
fladi:include-assets
Closed

fladi wants to merge 1 commit into
python:masterfrom
fladi:include-assets

Conversation

@fladi

@fladi fladi commented Aug 14, 2015

Copy link
Copy Markdown

It would be nice to have those files included in the source tarball.

@o11c

o11c commented Aug 15, 2015

Copy link
Copy Markdown
Contributor

Related: we ought to change travis to run unit tests against an installed version of mypy. Probably should switch to setuptools though.

@JukkaL

JukkaL commented Aug 16, 2015

Copy link
Copy Markdown
Collaborator

@fladi Thanks for the PR! Should we also include stubs (everything under stubs/)?

@o11c Not sure about that, as at least I almost always run unit tests in a local clone of the repo. However, we should verify that we can run the installed version of mypy.

@JukkaL

JukkaL commented Oct 18, 2015

Copy link
Copy Markdown
Collaborator

Hmm I already forgot what's the purpose of MANIFEST.in. It took me a while to figure out the last time because the name isn't very googleable. Anybody have context on this? The commit message should be more explicit about what this is used for.

@JukkaL

JukkaL commented Nov 2, 2015

Copy link
Copy Markdown
Collaborator

Closing as I don't have enough context to review this. Feel free to resend this PR with more context.

@JukkaL JukkaL closed this Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants