Repository navigation
Fix the logic in active self-type calculation for current scope - #7235
Merged
Merged
Conversation
JukkaL
approved these changes
Jul 18, 2019
|
|
||
| class C(B): | ||
| def __init__(self) -> None: | ||
| self.x: Any |
Collaborator
There was a problem hiding this comment.
What if the type is incompatible with the base class?
Member
Author
There was a problem hiding this comment.
Hm, I am not super happy with the error message, because it says:
Incompatible types in assignment (expression has type "int", base class "B" defined the type as "str")
while the initial type is T (it shows the mapped/expanded type). It is however not easy to improve, so I think it is OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5846
The fix for crash is kind of straightforward. Previously
active_self_type()always returnedNoneat method scope (sic!)While working on this I discovered couple other problems:
TypeInfo, one is fromlvalue.node.infoordefn.info, another is usingactive_self_type()(this is rather abusing it IMO). I don't try to fix this here (i.e. switch to always using one way) because this is a relatively large refactoring.CheckerScopeclass. Namely, there "top function" stays for "top of stack function", not "top-level function". I don't try to fix this here either because this is conceptually a big change.