Repository navigation
New semantic analyzer: fix redefining symbols as overloaded functions or classes - #6681
Merged
Merged
Conversation
added 2 commits
April 16, 2019 15:28
Member
Author
The idea of name mangling looks like a hack, but it works OK so far (we also use this for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6432
This is a hot fix that simply extends the solution in PR #6429 to more situations. We agreed with @JukkaL that he will clean this up when he is back from PTO.
Note that we still give the errors for redefinitions that we consider invalid (see tests), but we don't crash now.