Repository navigation
Add a SYMBOL_FUNCBASE_TYPES constant to avoid multiple-inheritance bug - #6481
Merged
Merged
Conversation
…sues A mypy bug (#3603) causes mypy to think that SymbolNodes cannot be FuncBases, which causes mypy-mypyc to crash in code that tests that. Currently we work around this in a couple gross ways (like turning the SymbolNode into Any). Work around it instead by testing directly against a tuple of the subtypes instead of FuncBase itself. This is the better fix promised in #6480.
gvanrossum
approved these changes
Feb 25, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LG, though I'm lukewarm on how much clarity this adds...
| super_info = node_node.info | ||
| if isinstance(node.node, Decorator): | ||
| super_info = node.node.var.info # type: Optional[TypeInfo] | ||
| elif isinstance(node.node, (Var, SYMBOL_FUNCBASE_TYPES)): |
Member
There was a problem hiding this comment.
So the hack now is that this is a variable and the binder doesn't know whether it's true or false?
Collaborator
Author
There was a problem hiding this comment.
There's no hack, anymore, really. We're just explicitly enumerating the overlap between SymbolNode and FuncBase instead of using isinstance on FuncBase
| cannot be a FuncBase. | ||
|
|
||
| Instead, test against SYMBOL_FUNCBASE_TYPES, which enumerates | ||
| SymbolNode subclasses that are also FuncBase subclasses. |
|
|
||
| # All types that are both SymbolNodes and FuncBases. See the FuncBase | ||
| # docstring for the rationale. | ||
| SYMBOL_FUNCBASE_TYPES = (OverloadedFuncDef, FuncDef) |
Member
There was a problem hiding this comment.
How do we ensure this stays up to date? If a new class were to be added, would tests for that new class fail clearly?
Collaborator
Author
There was a problem hiding this comment.
They would fail, I think, though I'm not sure how cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mypy bug (#3603) causes mypy to think that SymbolNodes cannot be
FuncBases, which causes mypy-mypyc to crash in code that tests
that.
Currently we work around this in a couple gross ways (like turning the
SymbolNode into Any). Work around it instead by testing directly
against a tuple of the subtypes instead of FuncBase itself.
This is the better fix promised in #6480.