Repository navigation
Fix interaction of isinstance() with Type[...] - #6419
Merged
Merged
Conversation
msullivan
approved these changes
Feb 22, 2019
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This seems reasonable. I wonder if there is a long-term way to clean up some of the complicated interactions involving Type, though
| item = left.item | ||
| if isinstance(item, TypeVarType): | ||
| item = item.upper_bound | ||
| if isinstance(item, Instance): |
Collaborator
There was a problem hiding this comment.
There is a "TODO: handle metaclasses?" comment above that I think can be removed now
Member
Author
I was thinking about this, but it looks like this part of the type system is inherently complex. (Especially if we want to keep it usable in practice.) Also there are still many holes in the type visitors, just few lines above is: def visit_overloaded(self, left: Overloaded) -> bool:
# TODO: What's the right thing to do here?
return FalseThe meet visitor (and related helpers) probably require the most attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4616
Fixes #6416
Fixes #6386
Currently
Type[C]is considered a subtype of metaclass ofC, and I think this is right. The idea is to fixProperSubtypeVisitor.visit_type_type()to matchSubtypeVisitor.visit_type_type()(plus couple small updates to make the former used byisinstance()andissubclass()).