Skip to content

Delete pyproject.toml to work around pip bug - #6342

Merged
gvanrossum merged 1 commit into
masterfrom
delete-pyproject
Feb 5, 2019
Merged

gvanrossum merged 1 commit into
masterfrom
delete-pyproject

Conversation

@msullivan

Copy link
Copy Markdown
Collaborator

We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.

We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.
@msullivan
msullivan requested a review from gvanrossum February 5, 2019 20:56
@gvanrossum

Copy link
Copy Markdown
Member

(CC: @gaborbernat who introduced this file.)

@gaborbernat

Copy link
Copy Markdown
Contributor

the latest setuptools released today introduced the legacy backend which will solve this issue

@gvanrossum
gvanrossum merged commit 05bbdc3 into master Feb 5, 2019
@gvanrossum
gvanrossum deleted the delete-pyproject branch February 5, 2019 21:38
gvanrossum pushed a commit to gvanrossum/mypy that referenced this pull request Feb 5, 2019
We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.
@msullivan

Copy link
Copy Markdown
Collaborator Author

Excellent. We'll revert this once there is a pip 19 release that defaults to using the legacy backend.

(We could directly ask to use it ourselves, but that seems dodgy since it has a bunch of underscores in the name and would make us require a very recent setuptools ourselves)

@gaborbernat

gaborbernat commented Feb 5, 2019 •

Copy link
Copy Markdown
Contributor

The main reasons for making it underscore is because importing from setup.py is considered a bad practice, not necessarily because it's actually dodgy using it.I think if we do want to really on importing from setup.py the version we might as well be upfront about it. I'll link in the discussion about the subject tomorrow. I'm not sure if pip will default to it though, AFAIK the intention is to be more like a bailout mechanism for packages who do want this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants