Repository navigation
Fix plugin invocation for __call__ methods - #6334
Merged
Merged
Conversation
Previously these would be delivered as a function hook for `__call__ of Foo`; now they are more properly a method hook for `__main__.Foo.__call__`.
ilevkivskyi
approved these changes
Feb 5, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! Looks good.
Closed
gvanrossum
pushed a commit
to gvanrossum/mypy
that referenced
this pull request
Feb 5, 2019
Previously these would be delivered as a function hook for `__call__ of Foo`; now they are more properly a method hook for `__main__.Foo.__call__`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these would be delivered as a function hook for
__call__ of Foo;now they are more properly a method hook for
__main__.Foo.__call__.Also make sure we call the method signature hook for
__call__methods.