Repository navigation
Fix small regression in subtype cache performance - #5604
Merged
Merged
Conversation
added 8 commits
September 11, 2018 20:12
Michael0x2a
approved these changes
Sep 12, 2018
Michael0x2a
left a comment
Michael0x2a
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I don't really have any feedback or nitpicks. I think this is good to merge once the tests pass.
Member
Author
|
I will cherry-pick this into release branch after merging. |
ilevkivskyi
added a commit
that referenced
this pull request
Sep 12, 2018
Fixes #5514 The root cause is that #5474 added `type_parameter_checker` (a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a _new_ function was created on every call to `is_subtype_ignoring_tvars()` causing many thousands parasitic keys created in subtype caches. In addition there are two smaller things listed below. The performance win is around 5% This PR: * Moves the mentioned function to global scope, this causes only 6 subtype kinds present during self-check. * Prevents similar regressions in future by switching only boolean flags as subtype kind keys. * Removes two one liners that stay in a very hot code path (cache lookup is hit 140K times during self-check). * Avoids creation of empty sets on cache look-up, create them only when writing to cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5514
The root cause is that #5474 added
type_parameter_checker(a function) as one of the keys of subtype kinds. This function is a nested one, so in fact a new function was created on every call tois_subtype_ignoring_tvars()causing many thousands parasitic keys created in subtype caches. In addition there are two smaller things listed below.The performance win is around 5%
This PR: