Skip to content

Fix some more type errors under mypyc - #5585

Merged
JukkaL merged 2 commits into
masterfrom
mypy-fixes
Sep 7, 2018
Merged

JukkaL merged 2 commits into
masterfrom
mypy-fixes

Conversation

@msullivan

Copy link
Copy Markdown
Collaborator

Add test cases for the constructs that triggered the trouble.

Add test cases for the constructs that triggered the trouble.
@msullivan msullivan mentioned this pull request Sep 7, 2018

@JukkaL JukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! These are good examples of errors in stubs and casts that mypyc helped find. Runtime type checking is not only useful for performance.

@JukkaL
JukkaL merged commit a0c2c1b into master Sep 7, 2018
@msullivan
msullivan deleted the mypy-fixes branch September 7, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants