Repository navigation
Conversation
This is to support Django-style usecases with patterns like `site.*.migrations.*`. The implementation works by mixing in the old-style glob matching with the new structured matching. Fixes #5014.
| [[mypy-spam.eggs] | ||
| [[mypy-emarg.*] | ||
| [[mypy-emarg.hatch] | ||
| [[mypy-a.*.b] |
There was a problem hiding this comment.
Why isn't a.*.b considered unused?
| Patterns may also be "unstructured" wildcards, in which ``*``s may | ||
| appear in the middle of a name (e.g | ||
| ``site.*.migrations.*``). Internal ``*``s match one or more module | ||
| component. |
There was a problem hiding this comment.
componentS. Also I'd write "stars" instead of "*s" (both places).
| for glob in unstructured_glob_keys: | ||
| self.glob_options.append((glob, re.compile(fnmatch.translate(glob)))) | ||
|
|
||
| # We (for ease of implementation), treat unstructured glob |
|
|
||
| # We (for ease of implementation), treat unstructured glob | ||
| # sections as used if any real modules use them or if any | ||
| # concrete config sections use them. This means we need to |
There was a problem hiding this comment.
Oh, this is a little shady, and explain why a.*.b is not an error in the test, right?
There was a problem hiding this comment.
Yeah I'll add a comment to the test.
| self.per_module_cache[key] = new_options | ||
|
|
||
| self.unused_configs = set(keys) | ||
| # Add the more structured sections into unused configs . |
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Some more requests for clarification of comments, and I think there's an issue with whether foo.bar matches foo.*.bar.
| # 2. "Unstructured" glob patterns: foo.*.baz, in the order they appear in the file | ||
| # 3. "Well-structured" wildcard patterns: foo.bar.*, in specificity order. | ||
|
|
||
| # Since structured configs inherit from glob configs above them in the hierarchy, |
There was a problem hiding this comment.
You don't explain "glob config" -- presumably this is the same as structured config? I.e. this implements the "in specificity order" of point 3 above.
| # Config precedence is as follows: | ||
| # 1. Concrete section names: foo.bar.baz | ||
| # 2. "Unstructured" glob patterns: foo.*.baz, in the order they appear in the file | ||
| # 3. "Well-structured" wildcard patterns: foo.bar.*, in specificity order. |
There was a problem hiding this comment.
This is a bit head-exploding, since conflict resolution for (2) is based on file order while for (3) it is based on pattern length.
Plus I don't have a good intuition whether "file order" means "first in file wins" or "last in file wins".
| # and we need to apply *.bar to foo.bar but not to foo.bar.*. | ||
| # To do this, process all well-structured glob configs before non-glob configs and | ||
| # exploit the fact that foo.* sorts earlier ASCIIbetically (unicodebetically?) | ||
| # than foo.bar.*. |
There was a problem hiding this comment.
Maybe also add (redundantly?) that "processed last" translates into "wins"?
| break | ||
|
|
||
| # OK and *now* we need to look for glob matches | ||
| if not module.endswith('.*'): |
There was a problem hiding this comment.
When would module ever end in a star?
| new_options.__dict__.update(options.__dict__) | ||
| new_options.__dict__.update(self.per_module_options[key]) | ||
| new_options = options.apply_changes(self.per_module_options[key]) | ||
| self.per_module_cache[key] = new_options |
There was a problem hiding this comment.
Perhaps combine with previous line? (Unless it doesn't fit.)
| concrete = [k for k in structured_keys if not k.endswith('.*')] | ||
|
|
||
| for glob in unstructured_glob_keys: | ||
| self.glob_options.append((glob, re.compile(fnmatch.translate(glob)))) |
There was a problem hiding this comment.
IIUC this means that module foo.bar does not match the pattern foo.*.bar. And that's surprising since foo.bar does matchs foo.bar.*.
|
(So maybe it's fine if foo.bar doesn't match foo.*.bar, but then it should
be called out in the docs.)
|
| # match *zero or more* module sections. This means we compile | ||
| # '.*' into '(\..*)?'. We also need to escape .s in the glob, so | ||
| # we hackily rewrite .s to ,s to accomplish this. | ||
| s = s.replace('.', ',').replace(',*', '(\..*)?').replace(',', '\.') |
There was a problem hiding this comment.
This doesn't work right for *.foo I think. Also maybe the code would be more readable if you just started with module.split('.') and applied re.escape() to parts that aren't *, and something else for other parts, special-casing a * at the front.
This is to support Django-style usecases with patterns like `site.*.migrations.*`. The implementation works by mixing in the old-style glob matching with the new structured matching. Fixes #5014.
2 participants
This is to support Django-style usecases with patterns like
site.*.migrations.*.The implementation works by mixing in the old-style glob matching with
the new structured matching.
Fixes #5014.