Repository navigation
Add checks for overlapping TupleTypes - #4238
Merged
Merged
Conversation
JukkaL
reviewed
Nov 15, 2017
| if all(is_overlapping_types(ti, si, use_promotions) | ||
| for ti, si in zip(t.items, s.items)): | ||
| return True | ||
| # TODO: Tuple[A, ...] |
Collaborator
There was a problem hiding this comment.
I think that this may work already -- Tuple[A, ...] is represented as an Instance, and the new check below should handle this (TupleType vs. Instance). Can you add a test case and remove this comment if I was correct?
Contributor
Author
There was a problem hiding this comment.
The case was not handled well, so I added support for it
Since unions can overlap with basically everything, checking for them first gives more confidence in later checks, such as tuple types and type types.
Contributor
Author
|
Added support for @JukkaL the logic is quite different now, so it needs to be re-reviewed... Sorry about that :\ There are many tests that can be added - involving combinations of tuples, namedtuple, varargs, instances and unions; but I prefer to do it in at a different time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4237.
This is not complete or bulletproof, but it's an improvement.
I don't see where should there be a special case for namedtuple; maybe there shouldn't.