Repository navigation
Python 3.4 support - #3733
Merged
Merged
Python 3.4 support#3733
Conversation
The new typed_ast 1.1.0 includes a patch adding support for Python 3.4 and 3.3. The README is updated to discuss this. A comment on LXML on Python 3.3/3.4 was added to help those whishing to use reports on Windows.
Member
|
Thanks! The requirements are a little white lie (on many platforms, typed_ast 1.0.4 works just fine) but since typed_ast 1.1.0 now exists on PyPI I don't mind. |
|
|
||
| C:\>\Python34\python \Python34\Scripts\mypy PROGRAM | ||
|
|
||
| If you are on Windows using Python 3.3 or 3.4, and would like to use XML reports |
Member
There was a problem hiding this comment.
Isn't this true for all Python versions? On my mac in a venv without lxml I get:
$ mypy --cobertura-xml-report mypy-report mypy/
You must install the lxml package before you can run mypy with `--cobertura-xml-report`.
You can do this with `python3 -m pip install lxml`.
Member
|
Oh, you're right -- feel free to submit a fix.
|
Member
Author
|
Actually, I meant that one cannot simply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new typed_ast 1.1.0 includes a patch adding support for Python 3.4
and 3.3. The README is updated to discuss this. A comment on LXML on
Python 3.3/3.4 was added in case there was someone who really wanted to use reports. Also I removed the comment about the difficulty/easy tag on issues as that isn't used anymore.
3.3 ends up being supported incidentally as it uses the same compiler as 3.4 (thus typed_ast supports it, so we do).
lxml in test-requirements is not updated due to lxml not supplying wheels for Python 3.4 64 bit.