Repository navigation
Conversation
JukkaL
reviewed
Dec 2, 2016
| if (isinstance(replacements, DictExpr) and | ||
| all(isinstance(k, (StrExpr, BytesExpr)) | ||
| for k, v in replacements.items)): | ||
| if isinstance(replacements, DictExpr): |
Collaborator
There was a problem hiding this comment.
This is generally not right. Consider this example:
x = 'q'
'%(q)d' % {'a': 1, x: 2} # actually okayWhat about still using the all(...) check (include also unicode), but only for the key_not_in_mapping error? Item types can still be checked even if some keys are not literals -- we can assume that there are no duplicate keys.
Collaborator
There was a problem hiding this comment.
What about the case with a non-literal key? It might be pretty rare, but here's one example where it would be kind of reasonable:
# constants.py
key1 = 'key1'
key2 = 'key2'
# code.py
from constants import key1, key2
...
'%(key1)d, %(key2)d' % {key1: 1, key2: 2}
Not sure whether we are likely to encounter code like that in practice.
Member
|
Let me just close this; it's over 4 months old. If you're still interested just create a new PR (or reopen this one if GitHub supports that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.