Repository navigation
Add changelog for 1.9.0 - #16978
Merged
Merged
Add changelog for 1.9.0#16978
Conversation
cdce8p
reviewed
Mar 1, 2024
|
|
||
| #### Breaking Changes | ||
|
|
||
| Because the version of typeshed we use in mypy 1.9 doesn't support 3.7, neither does mypy 1.9. (Marc Mueller, PR [16900](https://github.com/python/mypy/pull/16900)) |
Collaborator
There was a problem hiding this comment.
That was your PR. I just backported it 😅
See: #16883
| * Apply TypeVar defaults to callables (PEP 696) (Marc Mueller, PR [16842](https://github.com/python/mypy/pull/16842)) | ||
| * Use TypeVar defaults instead of Any when fixing TypeAlias types (PEP 696) (Marc Mueller, PR [16825](https://github.com/python/mypy/pull/16825)) | ||
| * Use TypeVar defaults instead of Any when fixing instance types (PEP 696) (Marc Mueller, PR [16812](https://github.com/python/mypy/pull/16812)) | ||
| * Consider TypeVarTuple to be invariant (Marc Mueller, PR [16759](https://github.com/python/mypy/pull/16759)) |
Collaborator
There was a problem hiding this comment.
I would suggest to move this one to the Miscellaneous Fixes section.
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks, left a few suggestions
| * Stubtest will ignore private function/method parameters when they are missing from the stub. | ||
| Private parameters names start with a single underscore and have a default | ||
| (PR [16507](https://github.com/python/mypy/pull/16507)). | ||
| * Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
Member
There was a problem hiding this comment.
Suggested change
| * Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) | |
| * Stubtest: ignore a new protocol dunder (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
Member
There was a problem hiding this comment.
...This was my PR, Marc just cherry-picked it to the release-1.9 branch :)
cdce8p
reviewed
Mar 1, 2024
| * Stubtest will ignore private function/method parameters when they are missing from the stub. | ||
| Private parameters names start with a single underscore and have a default | ||
| (PR [16507](https://github.com/python/mypy/pull/16507)). | ||
| * Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Stubtest: ignore a new protocol dunder (#16895) (Marc Mueller, PR [16899](https://github.com/python/mypy/pull/16899)) | |
| * Stubtest: ignore a new protocol dunder (Alex Waygood, PR [16895](https://github.com/python/mypy/pull/16895)) |
This was also only a cherry-pick PR. Linked the correct one here.
cdce8p
reviewed
Mar 1, 2024
Hnasar
reviewed
Mar 1, 2024
| * Use TypeVar defaults instead of Any when fixing instance types (PEP 696) (Marc Mueller, PR [16812](https://github.com/python/mypy/pull/16812)) | ||
| * Consider TypeVarTuple to be invariant (Marc Mueller, PR [16759](https://github.com/python/mypy/pull/16759)) | ||
|
|
||
| #### Miscellaneous Fixes |
Contributor
There was a problem hiding this comment.
Consider combining Plugin Improvements and Miscellaneous Fixes and name it Type-checking Improvements similar to the notes for release 1.8.
and maybe further up, above below the new typechecking features.
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
cdce8p
reviewed
Mar 1, 2024
Co-authored-by: Marc Mueller <[email protected]>
JukkaL
approved these changes
Mar 4, 2024
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I'll do some editing in a separate PR after merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did my best to sort them out in a way I thought was reasonable, but feel free to suggest improvements. I also removed a few that were linter version updates etc.