Skip to content

Test with 32-bit Python - #14634

Merged
hauntsaninja merged 1 commit into
python:masterfrom
mr-c:test-x86
Feb 15, 2023
Merged

Test with 32-bit Python#14634
hauntsaninja merged 1 commit into
python:masterfrom
mr-c:test-x86

Conversation

@mr-c

@mr-c mr-c commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Debian does build 32bit (on Linux), and there was a recent regression

This PR would have caught #14633 earlier

No change in total CI time (32 minutes) versus the baseline (33 minutes)

Confirmation that the new CI test catches the previous error is at https://github.com/python/mypy/actions/runs/4174055572/jobs/7227150570#step:7:44

@github-actions

This comment has been minimized.

Sign in to view
@JukkaL

JukkaL commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

Yeah, we should probably continue testing on a 32-bit architecture. Maybe just running mypyc tests would be enough to catch most issues? Windows CI tends to be pretty slow.

@mr-c

mr-c commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yeah, we should probably continue testing on a 32-bit architecture. Maybe just running mypyc tests would be enough to catch most issues? Windows CI tends to be pretty slow.

That or cross-compiling to x86 under Linux; whichever works!

@JukkaL

JukkaL commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

That or cross-compiling to x86 under Linux; whichever works!

I'm not sure how easy this would be to set up in GitHub actions. We might need to use Docker, which may be too involved. Continuing to use 32-bit Windows may be our best bet, but without running the entire test suite.

@github-actions

This comment has been minimized.

Sign in to view
@mr-c

mr-c commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I rebased on top of @JukkaL 's 32-bit test case fixes in 563e29d

There are some failures, but I think they are just from path changes
https://github.com/python/mypy/actions/runs/4172280556/jobs/7223187539#step:8:202

FAILED mypy/test/testfinegrained.py::FineGrainedSuite::fine-grained-suggest.test::testSuggestColonMethodJSON

Alignment of first line difference:
  E: ..., "line": 3, "path": "tmp/foo.py", "samples": 0, "signature": {"arg_t...
  A: ..., "line": 3, "path": "C:/Users/RUNNER~1/AppData/Local/Temp/mypy-test-...
                              ^

FAILED mypyc/test/test_run.py::TestRun::run-loops.test::testForIterable

Alignment of first line difference:
  E:   File "driver.py", line 16, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-2afcrxij\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-exceptions.test::testException

Alignment of first line difference:
  E:   File "driver.py", line 4, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-63wapg7j\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-exceptions.test::testTryExcept

Alignment of first line difference:
  E:   File "driver.py", line 6, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-kx2rlobh\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-exceptions.test::testExceptionAtModuleTopLevel

Alignment of first line difference:
  E:   File "driver.py", line 3, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-njz3rjwc\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-classes.test::testSubclassUninitAttr

 Alignment of first line difference:
  E:   File "driver.py", line 4, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-hb3g0dzm\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-generators.test::testYieldThrow

 Alignment of first line difference:
  E:   File "driver.py", line 31, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-voe0j96t\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-classes.test::testProperty


Alignment of first line difference:
  E:   File "driver.py", line 5, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-45xmabsc\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRun::run-multimodule.test::testMultiModuleTraceback

 Alignment of first line difference:
  E:   File "driver.py", line 6, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-cacveqm3\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRunMultiFile::run-multimodule.test::testMultiModuleTraceback_multi


Alignment of first line difference:
  E:   File "driver.py", line 6, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-_g8qvv4c\tmp\driv...
             ^

FAILED mypyc/test/test_run.py::TestRunSeparate::run-multimodule.test::testMultiModuleTraceback_separate


Alignment of first line difference:
  E:   File "driver.py", line 6, in <module>...
  A:   File "C:\Users\RUNNER~1\AppData\Local\Temp\mypy-test-k8mxhwba\tmp\driv...
             ^

@mr-c
mr-c force-pushed the test-x86 branch 5 times, most recently from 79ddeeb to 8554dbb Compare February 14, 2023 11:51
@mr-c mr-c changed the title Test with 32-bit on Windows again Test with 32-bit Python Feb 14, 2023
@github-actions

This comment has been minimized.

Sign in to view
@mr-c
mr-c force-pushed the test-x86 branch 3 times, most recently from 75a4157 to a1aaa87 Compare February 14, 2023 13:03
@mr-c
CI: Cross-compile 32-bit Linux Python
8f56ede 
Debian does build 32bit and there was a recent regression
@mr-c
mr-c marked this pull request as ready for review February 14, 2023 13:19
@mr-c

mr-c commented Feb 14, 2023

Copy link
Copy Markdown
Contributor Author

@JukkaL I added 32-bit Linux testing (instead of MS Windows), updated the description, and marked this PR as ready for review

@github-actions

github-actions Bot commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

hauntsaninja
hauntsaninja approved these changes Feb 15, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja
hauntsaninja merged commit 0bbeab8 into python:master Feb 15, 2023
@mr-c
mr-c deleted the test-x86 branch February 15, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mr-c @JukkaL @hauntsaninja