Repository navigation
Implement miscellaneous fixes for partially-defined check - #14175
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Nov 23, 2022
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, but there are couple questions about dotted imports.
Collaborator
Author
Good catch on these! Thanks! |
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
reviewed
Nov 25, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
@ilevkivskyi I'm going to merge this because I'm pretty sure it's correct now but please take a look at the imports implementation if you get the chance :) I'll send a follow-up PR if something is actually broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the issues that I've found using mypy-primer.
You should be able to review this PR commit-by-commit. Each commit includes the relevant tests:
strand__doc__)