Repository navigation
Correcting the pyinfo.py file - #12207
soma2000-lang wants to merge 1 commit into
Conversation
|
@hauntsaninja Please look into this |
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Hi, thank you for your PR. Unfortunately, these changes are not correct. The file does have to run under Python 2 (at least for now) since mypy can still type check Python 2 code. In addition, your change to the return of the getprefixes() function is not correct, instead of returning both the base_prefix and prefix (note the return type is a tuple of str), it will only return the prefix if the base prefix is None or the empty string.
|
Oh I see you are trying to fix #12202. In that case I would change the check to be |
|
Thank you, but superseded by #12244 |
3 participants
Description
Made some change in the code
https://github.com/python/mypy/blob/master/mypy/pyinfo.py#L22
Test Plan
fixes issue #12202