[backport] cherry-pick slice-syntax fix for 0.920 by Zac-HD · Pull Request #11406 · python/mypy

Zac-HD · 2021-10-29T10:00:02Z

This PR cherrypicks #11345 onto the 0.920 release branch, as requested by @ilevkivskyi in #11158 (comment).

Zac-HD · 2021-10-29T10:29:48Z

Looks like this is failing with an unrelated pip install error?

__________________________ testPep561TestIncremental ___________________________
[gw1] linux -- Python 3.9.7 /home/runner/work/mypy/mypy/.tox/py/bin/python
data: /home/runner/work/mypy/mypy/test-data/unit/pep561.test:180:
/home/runner/work/mypy/mypy/mypy/test/testpep561.py:30: in run_case
    test_pep561(test_case)
/home/runner/work/mypy/mypy/mypy/test/testpep561.py:107: in test_pep561
    install_package(pkg, python_executable, use_pip, editable)
/home/runner/work/mypy/mypy/mypy/test/testpep561.py:77: in install_package
    raise Exception(proc.stdout.decode('utf-8') + proc.stderr.decode('utf-8'))
E   Exception: 
E   Usage:   
E     /tmp/tmpeczd7udv/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
E     /tmp/tmpeczd7udv/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
E     /tmp/tmpeczd7udv/bin/python -m pip install [options] [-e] <vcs project url> ...
E     /tmp/tmpeczd7udv/bin/python -m pip install [options] [-e] <local project path> ...
E     /tmp/tmpeczd7udv/bin/python -m pip install [options] <archive url/path> ...
E   
E   no such option: -b

emmatyping · 2021-10-29T10:38:19Z

Yeah we should also probably cherry pick #11356

ilevkivskyi · 2021-10-29T10:40:02Z

OK, I can cp that.

Btw there is also another failure

  main:3: error: syntax error in type comment   (diff)
Actual:
  main:2: error: Module "typing" has no attribute "Dict" (diff)
  main:2: note: Maybe your test fixture does not define "builtins.dict"? (diff)
  main:2: note: Consider adding [builtins fixtures/dict.pyi] to your test description (diff)

ilevkivskyi · 2021-10-29T10:44:36Z

I just cherry-picked that commit.

Zac-HD · 2021-10-29T10:47:55Z

Ah, that was related to #11241 I think, which this cherrypick skipped over.

ilevkivskyi · 2021-10-29T10:47:59Z

Btw does anyone know why we don't run tests on the release branch itself? (I see no green checkmarks on CPs here https://github.com/python/mypy/commits/release-0.920)

ilevkivskyi · 2021-10-29T10:49:38Z

cc @hauntsaninja (the question above about tests)

This is useful for Annotated, and crucial for downstream libraries like torchtyping.

github-actions · 2021-10-29T11:23:42Z

Diff from mypy_primer, showing the effect of this PR on open source code:

pip (https://github.com/pypa/pip.git)
- src/pip/_internal/commands/debug.py:50: error: unused "type: ignore" comment

core (https://github.com/home-assistant/core.git)
- homeassistant/components/http/__init__.py:299: error: unused "type: ignore[arg-type, misc]" comment
+ homeassistant/components/http/__init__.py:299: error: unused "type: ignore" comment
- homeassistant/components/devolo_home_network/__init__.py:52: error: unused "type: ignore[union-attr]" comment
- homeassistant/components/devolo_home_network/__init__.py:60: error: unused "type: ignore[union-attr]" comment
- homeassistant/components/devolo_home_network/__init__.py:68: error: unused "type: ignore[union-attr]" comment
- homeassistant/components/bmw_connected_drive/sensor.py:396: error: unused "type: ignore" comment
- homeassistant/components/bmw_connected_drive/sensor.py:402: error: unused "type: ignore" comment

ignite (https://github.com/pytorch/ignite)
- ignite/engine/deterministic.py:255: error: unused "type: ignore[arg-type, attr-defined]" comment
+ ignite/engine/deterministic.py:255: error: unused "type: ignore" comment
- ignite/engine/deterministic.py:260: error: unused "type: ignore[attr-defined, union-attr]" comment
+ ignite/engine/deterministic.py:260: error: unused "type: ignore" comment

mypy (https://github.com/python/mypy.git)
+ mypy/nodes.py:67: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/nodes.py:67: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:211: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/nodes.py:211: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:232: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:232: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:235: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:235: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:244: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/nodes.py:244: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:304: error: Variable "mypy.nodes.Definition" is not valid as a type  [valid-type]
+ mypy/nodes.py:304: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:325: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:325: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:335: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:335: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:452: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:452: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:456: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:456: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:517: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/nodes.py:517: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:532: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:532: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:533: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:533: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:534: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:534: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:536: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:536: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:557: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:557: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:567: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:567: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:570: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:570: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:573: error: Variable "mypy.nodes.OverloadPart" is not valid as a type  [valid-type]
+ mypy/nodes.py:573: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:723: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:723: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:741: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:741: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:815: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:815: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:823: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:823: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:923: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:923: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:926: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:926: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:938: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:938: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:999: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:999: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1009: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:1009: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1098: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1098: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1117: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1117: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1138: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1138: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1141: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1141: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1174: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1174: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1190: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1190: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1241: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1241: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1243: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1243: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1341: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1341: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1349: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:1349: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:1607: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:1607: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2026: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:2026: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2028: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:2028: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2082: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:2082: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2084: error: Variable "mypy.nodes.Lvalue" is not valid as a type  [valid-type]
+ mypy/nodes.py:2084: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2226: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2226: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2236: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2236: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2251: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2251: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2261: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2261: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2579: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2579: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2778: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2778: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2803: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2803: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2997: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2997: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:2998: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:2998: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3014: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3014: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3093: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3093: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3223: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3223: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3230: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3230: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3261: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3261: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3311: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3311: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3312: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3312: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3324: error: Variable "mypy.nodes.JsonDict" is not valid as a type  [valid-type]
+ mypy/nodes.py:3324: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/nodes.py:3425: error: Variable "mypy.nodes.Definition" is not valid as a type  [valid-type]
+ mypy/nodes.py:3425: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:26: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/types.py:26: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:55: error: Variable "typing_extensions.TypeAlias" is not valid as a type  [valid-type]
+ mypy/types.py:55: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:119: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:119: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:160: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:160: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:164: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:164: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:262: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:262: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:264: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:264: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:272: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:272: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:382: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:382: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:386: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:386: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:425: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:425: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:437: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:437: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:457: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:457: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:467: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:467: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:547: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:547: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:556: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:556: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:588: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:588: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:613: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:613: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:675: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:675: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:681: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:681: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:731: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:731: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:736: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:736: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:764: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:764: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:768: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:768: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ mypy/types.py:808: error: Variable "mypy.types.JsonDict" is not valid as a type  [valid-type]
+ mypy/types.py:808: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
- mypy/fastparse.py:102: error: Return type becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:284: error: Argument 1 to "is_no_type_check_decorator" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:309: error: Type of variable becomes "Dict[type, Callable[[Optional[Any]], Any]]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:322: error: Argument 2 to "visit" becomes "Optional[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:333: error: Argument 3 to "set_line" becomes "Union[Any, Any, Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:339: error: Argument 2 to "translate_opt_expr_list" becomes "Sequence[Optional[Any]]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:346: error: Argument 2 to "translate_expr_list" becomes "Sequence[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:349: error: Argument 2 to "get_lineno" becomes "Union[Any, Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:355: error: Argument 2 to "translate_stmt_list" becomes "Sequence[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:375: error: Argument 2 to "translate_type_comment" becomes "Union[Any, Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:390: error: Type of variable becomes "Dict[Type[Any], str]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:406: error: Argument 2 to "from_operator" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:413: error: Type of variable becomes "Dict[Type[Any], str]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:426: error: Argument 2 to "from_comp_operator" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:433: error: Argument 2 to "as_block" becomes "List[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:440: error: Argument 2 to "as_required_block" becomes "List[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:496: error: Argument 2 to "visit_Module" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:516: error: Argument 2 to "visit_FunctionDef" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:521: error: Argument 2 to "visit_AsyncFunctionDef" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:524: error: Argument 2 to "do_func_def" becomes "Union[Any, Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:664: error: Argument 2 to "transform_args" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:670: error: Type of variable becomes "List[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:671: error: Redundant cast to "List[Any]"  [redundant-cast]
- mypy/fastparse.py:671: error: Target type of cast becomes "List[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:710: error: Argument 2 to "make_argument" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:710: error: Argument 3 to "make_argument" becomes "Optional[Any]" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:729: error: Argument 3 to "fail_arg" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:737: error: Argument 2 to "visit_ClassDef" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:762: error: Argument 2 to "visit_Return" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:767: error: Argument 2 to "visit_Delete" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:777: error: Argument 2 to "visit_Assign" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:785: error: Argument 2 to "visit_AnnAssign" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:800: error: Argument 2 to "visit_AugAssign" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:807: error: Argument 2 to "visit_For" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:817: error: Argument 2 to "visit_AsyncFor" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:828: error: Argument 2 to "visit_While" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:835: error: Argument 2 to "visit_If" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:843: error: Argument 2 to "visit_With" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:852: error: Argument 2 to "visit_AsyncWith" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:862: error: Argument 2 to "visit_Raise" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:867: error: Argument 2 to "visit_Try" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:883: error: Argument 2 to "visit_Assert" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:888: error: Argument 2 to "visit_Import" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:904: error: Argument 2 to "visit_ImportFrom" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:917: error: Argument 2 to "visit_Global" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:922: error: Argument 2 to "visit_Nonlocal" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:927: error: Argument 2 to "visit_Expr" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:933: error: Argument 2 to "visit_Pass" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:938: error: Argument 2 to "visit_Break" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:943: error: Argument 2 to "visit_Continue" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:954: error: Argument 2 to "visit_BoolOp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:968: error: Argument 4 to "group" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:976: error: Argument 2 to "visit_BinOp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:986: error: Argument 2 to "visit_UnaryOp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1004: error: Argument 2 to "visit_Lambda" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1015: error: Argument 2 to "visit_IfExp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1022: error: Argument 2 to "visit_Dict" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1028: error: Argument 2 to "visit_Set" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1033: error: Argument 2 to "visit_ListComp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1034: error: Target type of cast becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1038: error: Argument 2 to "visit_SetComp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1039: error: Target type of cast becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1043: error: Argument 2 to "visit_DictComp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1057: error: Argument 2 to "visit_GeneratorExp" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1070: error: Argument 2 to "visit_Await" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1076: error: Argument 2 to "visit_Yield" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1081: error: Argument 2 to "visit_YieldFrom" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1086: error: Argument 2 to "visit_Compare" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1094: error: Argument 2 to "visit_Call" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1134: error: Argument 2 to "visit_Num" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1151: error: Argument 2 to "visit_Str" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1162: error: Argument 2 to "visit_JoinedStr" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1181: error: Argument 2 to "visit_FormattedValue" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1201: error: Argument 2 to "visit_Bytes" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1206: error: Argument 2 to "visit_NameConstant" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1211: error: Argument 2 to "visit_Ellipsis" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1216: error: Argument 2 to "visit_Attribute" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1229: error: Argument 2 to "visit_Subscript" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1247: error: Argument 2 to "visit_Starred" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1252: error: Argument 2 to "visit_Name" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1257: error: Argument 2 to "visit_List" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1267: error: Argument 2 to "visit_Tuple" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1274: error: Argument 2 to "visit_Slice" becomes "Any" due to an unfollowed import  [no-any-unimported]
- mypy/fastparse.py:1280: error```

This comment has been minimized.

Sign in to view

Allow slice syntax

a482b6b

This is useful for Annotated, and crucial for downstream libraries like torchtyping.

Zac-HD force-pushed the allow-slice-syntax branch from 9bd809d to a482b6b Compare October 29, 2021 11:04

This comment has been minimized.

Sign in to view

ilevkivskyi merged commit e4c52ee into python:release-0.920 Oct 29, 2021

Zac-HD deleted the allow-slice-syntax branch October 29, 2021 11:57

hauntsaninja mentioned this pull request Oct 29, 2021

Run tests on release branches #11409

Merged

Navigation Menu

Repository navigation

[backport] cherry-pick slice-syntax fix for 0.920 - #11406

[backport] cherry-pick slice-syntax fix for 0.920#11406
ilevkivskyi merged 1 commit into
python:release-0.920from
Zac-HD:allow-slice-syntax

Zac-HD commented Oct 29, 2021

Uh oh!

This comment has been minimized.

Zac-HD commented Oct 29, 2021

Uh oh!

emmatyping commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

Zac-HD commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Zac-HD commented Oct 29, 2021

Uh oh!

This comment has been minimized.

Zac-HD commented Oct 29, 2021

Uh oh!

emmatyping commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

Zac-HD commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

ilevkivskyi commented Oct 29, 2021

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants