Repository navigation
[mypyc] Fix division of negative tagged int - #11168
Merged
Merged
Conversation
The rounding was incorrect for some negative values, because of a bug related to the tagged integer logic. For example, -5 // 2 evaluated to -4 instead of -3 (ouch). Change the rounding implementation to not use shifted integers. Also add more exhaustive testing and fix a broken integer test case.
ilevkivskyi
approved these changes
Sep 22, 2021
ilevkivskyi
pushed a commit
that referenced
this pull request
Sep 23, 2021
The rounding was incorrect for some negative values, because of a bug related to the tagged integer logic. For example, -5 // 2 evaluated to -4 instead of -3 (ouch). Change the rounding implementation to not use shifted integers. Also add more exhaustive testing and fix a broken integer test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rounding was incorrect for some negative values, because of a bug
related to the tagged integer logic. For example, -5 // 2 evaluated to
-4 instead of -3 (ouch). Change the rounding implementation to not use
shifted integers.
Also add more exhaustive testing and fix a broken integer test case.