Repository navigation
Stop running Python 3.5 in CI - #10345
Merged
Merged
Conversation
Python 3.5 always fails in CI these days Linking python#9950
emmatyping
approved these changes
Apr 20, 2021
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
I look forward to dropping support so we can use TypeVar without needing to guard it.
Collaborator
|
Agreed. Should we keep the number of compiled suites by making 3.6 compiled? |
Collaborator
Author
|
You probably have a better sense of that than I do — how likely is it that 3.6 compiled will catch issues not caught by 3.7 compiled and 3.6? |
Collaborator
Author
|
I do seem to remember we had a CI false negative once because we didn't have a compiled >= 3.8 (due to some typeshed change to ast), so maybe we make Python 3.9 compiled |
TH3CHARLie
approved these changes
Apr 21, 2021
TH3CHARLie
left a comment
TH3CHARLie
left a comment
Collaborator
There was a problem hiding this comment.
A compiled 3.9 LGTM!
Collaborator
|
I think that we should run compiled tests on the earliest supported/working Python version and the latest, so it would be 3.6 and 3.9 after this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.5 always fails in CI these days. So a) it's annoying and a bad contributor experience, b) we're effectively not testing against Python 3.5 anyway
Linking #9950