Skip to content

removed analysis.py is still used in ./mypyc/transform/uninit.py #9584

Closed

Description

@doko42

seen when trying to generate manual pages with 0.790 and python3.9:

I: pybuild base:217: /usr/bin/python3.9 setup.py build
Traceback (most recent call last):
File "/packages/tmp/mypy-0.790/setup.py", line 144, in
from mypyc.build import mypycify
File "/packages/tmp/mypy-0.790/mypyc/build.py", line 43, in
from mypyc.codegen import emitmodule
File "/packages/tmp/mypy-0.790/mypyc/codegen/emitmodule.py", line 41, in
from mypyc.transform.uninit import insert_uninit_checks
File "/packages/tmp/mypy-0.790/mypyc/transform/uninit.py", line 5, in
from mypyc.analysis.dataflow import (
ModuleNotFoundError: No module named 'mypyc.analysis'

apparently the analysis module was removed, however mypyc/transform/uninit.py still uses it

Activity

  1. hauntsaninja commented on Oct 12, 2020

    @hauntsaninja
    Collaborator

    https://github.com/python/mypy/tree/master/mypyc/analysis still exists
    I can't repro with python3.9 setup.py build on master, so closing. Feel free to reopen with more details :-)

  2. added a commit that references this issue on Oct 13, 2020
    f6522ae
  3. JelleZijlstra commented on Oct 13, 2020

    @JelleZijlstra
    Member

    I haven't tried to repro this, but noticed that mypyc.analysis is missing from setup.py, so I submitted a PR to fix it.

  4. doko42 commented on Oct 13, 2020

    @doko42
    MemberAuthor

    re-adding this module lets the build continue, and then it fails with (building from the release tarball):

    mypy/fastparse.py:1260: error: "ExtSlice" has no attribute "dims"
    mypy/fastparse.py:1264: error: "Index" has no attribute "value"

  5. added a commit that references this issue on Oct 13, 2020
    92a5cbd
  6. TH3CHARLie commented on Oct 13, 2020

    @TH3CHARLie
    Collaborator

    re-adding this module lets the build continue, and then it fails with (building from the release tarball):

    mypy/fastparse.py:1260: error: "ExtSlice" has no attribute "dims"
    mypy/fastparse.py:1264: error: "Index" has no attribute "value"

    I think these errors are not related to the PR which closes this issue, these failures, I guess, are related to typeshed, maybe @hauntsaninja has some insight on this.

  7. hauntsaninja commented on Oct 13, 2020

    @hauntsaninja
    Collaborator

    I fixed these last week in #9552 and #9562. If you pull those in, compiling with mypyc works.
    (Note that 0.790 doesn't officially support 3.9 — https://mypy-lang.blogspot.com/2020/10/mypy-0790-released.html)

  8. added a commit that references this issue on Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmypy got something wrong

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions