Skip to content

Update fastparse for 3.9 AST changes #8627

Closed

Description

@msullivan

In 3.9.0a5, some changes landed to the AST for subscripting (python/cpython#9605). We need to support them.

This first got reported in #8614 as "syntax error in type comment", which is pretty bad, also! We should clean up that error message when we fix this.

Activity

  1. added 4 commits that reference this issue on Apr 6, 2020
    5a161e3
    ad0ae36
    deaaccf
    58fb02c
  2. cooperlees commented on Apr 11, 2020

    @cooperlees

    If it helps, I've got CI failing 3.9.0a5 here with the same error: https://travis-ci.org/github/cooperlees/aioexabgp/jobs/673829413

    • If not, please ignore.
    • Happy to help test anything if needed

    Thanks, subscribing.

  3. gvanrossum commented on Apr 23, 2020

    @gvanrossum
    Member

    Do you need help with this? I reviewed the CPython change and I can probably figure out how to do this easily.

  4. added a commit that references this issue on Apr 23, 2020
    43cb4eb
  5. added a commit that references this issue on Apr 25, 2020
    125728a
  6. jaraco commented on May 23, 2020

    @jaraco
    Member

    I'm attempting to test against Python 3.9b1, but the test suite is failing with the "syntax error in type comment". Does this patch fix it? Is a release planned?

  7. 6 remaining items

  8. added a commit that references this issue on Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions