You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for fixing that one! I just checked our codebase against master again and got a few other errors: #5124 (almost certainly related to the overload refactor that won't go into 0.610) and a false positive about an incompatible return type on an async method with a decorator, which I haven't had time to minimize yet.
OK since the pace of things that we need to cherry-pick has been continuing unabated all week, I am postponing the release another week so that we can validate it more.
I plan to cherry-pick #5132 and #5126, and then we will hopefully have an actual "release candidate".
(Though there will still be a documentation patch I need to write and cherry-pick.)
Just wanted to say what a massive difference 0.610 has made to my daily workflow. Having flycheck on emacs run dmypy run instead of mypy check is like night and day, and has made day to day coding so much more enjoyable. Thanks a lot 👍
Activity
gvanrossum commentedon May 22, 2018
So we definitely need to do something about google/protobuf in typeshed (python/typeshed#2154), i.e. PR python/typeshed#2157 (now merged into master).
msullivan commentedon May 24, 2018
Actually we're gonna cut the release branch on Tuesday, because Monday is a holiday in the United States
msullivan commentedon May 30, 2018
Going to cut the release branch today, but postponing the release until Monday
msullivan commentedon May 30, 2018
Release branch is cut, with a cherry pick to include #5120 but exclude #5084.
I have a documentation patch about
dmypy runthat I intend to write and cherry-pick. I don't think we have any other planned cherry picks?ilevkivskyi commentedon May 30, 2018
👍 Perfect!
JelleZijlstra commentedon May 30, 2018
#5122 should be a release blocker.
ilevkivskyi commentedon May 30, 2018
Hm, I think I can fix it. I reviewed the PR that likely causes this.
JelleZijlstra commentedon May 30, 2018
Thanks for fixing that one! I just checked our codebase against master again and got a few other errors: #5124 (almost certainly related to the overload refactor that won't go into 0.610) and a false positive about an incompatible return type on an async method with a decorator, which I haven't had time to minimize yet.
ilevkivskyi commentedon May 30, 2018
Overload PR is not in the release branch, see above. I am much more interested in
Because this one is in the release branch.
JelleZijlstra commentedon May 30, 2018
#5125.
[Edit: this might not be a bug and doesn't need to block the release.]
msullivan commentedon May 31, 2018
#5123 cherry-picked
msullivan commentedon May 31, 2018
Oh and #5053 should be probablydonemsullivan commentedon Jun 1, 2018
OK since the pace of things that we need to cherry-pick has been continuing unabated all week, I am postponing the release another week so that we can validate it more.
I plan to cherry-pick #5132 and #5126, and then we will hopefully have an actual "release candidate".
(Though there will still be a documentation patch I need to write and cherry-pick.)
msullivan commentedon Jun 1, 2018
I believe that f3cb59a is now a release candidate.
msullivan commentedon Jun 6, 2018
Cherry picking the documentation patch #5157
msullivan commentedon Jun 7, 2018
Cherry picked the documentation patch #5164
msullivan commentedon Jun 8, 2018
Release out!
timwraight commentedon Jun 20, 2018
Just wanted to say what a massive difference 0.610 has made to my daily workflow. Having flycheck on emacs run
dmypy runinstead ofmypy checkis like night and day, and has made day to day coding so much more enjoyable. Thanks a lot 👍