Skip to content

Release 0.610 planning #5096

Closed
Closed

Description

@msullivan

I'd like to release mypy 0.610 on Friday June 8. Aiming to cut the release branch on Tuesday May 29.

If there are any PRs that urgently need merged, mention them here.

Activity

  1. self-assigned this
    on May 22, 2018
  2. gvanrossum commented on May 22, 2018

    @gvanrossum
    Member

    So we definitely need to do something about google/protobuf in typeshed (python/typeshed#2154), i.e. PR python/typeshed#2157 (now merged into master).

  3. msullivan commented on May 24, 2018

    @msullivan
    CollaboratorAuthor

    Actually we're gonna cut the release branch on Tuesday, because Monday is a holiday in the United States

  4. msullivan commented on May 30, 2018

    @msullivan
    CollaboratorAuthor

    Going to cut the release branch today, but postponing the release until Monday

  5. msullivan commented on May 30, 2018

    @msullivan
    CollaboratorAuthor

    Release branch is cut, with a cherry pick to include #5120 but exclude #5084.

    I have a documentation patch about dmypy run that I intend to write and cherry-pick. I don't think we have any other planned cherry picks?

  6. ilevkivskyi commented on May 30, 2018

    @ilevkivskyi
    Member

    Release branch is cut, with a cherry pick to include #5120 but exclude #5084.

    👍 Perfect!

  7. JelleZijlstra commented on May 30, 2018

    @JelleZijlstra
    Member

    #5122 should be a release blocker.

  8. ilevkivskyi commented on May 30, 2018

    @ilevkivskyi
    Member

    Hm, I think I can fix it. I reviewed the PR that likely causes this.

  9. JelleZijlstra commented on May 30, 2018

    @JelleZijlstra
    Member

    Thanks for fixing that one! I just checked our codebase against master again and got a few other errors: #5124 (almost certainly related to the overload refactor that won't go into 0.610) and a false positive about an incompatible return type on an async method with a decorator, which I haven't had time to minimize yet.

  10. ilevkivskyi commented on May 30, 2018

    @ilevkivskyi
    Member

    Overload PR is not in the release branch, see above. I am much more interested in

    a false positive about an incompatible return type on an async method with a decorator

    Because this one is in the release branch.

  11. JelleZijlstra commented on May 30, 2018

    @JelleZijlstra
    Member

    #5125.

    [Edit: this might not be a bug and doesn't need to block the release.]

  12. msullivan commented on May 31, 2018

    @msullivan
    CollaboratorAuthor

    #5123 cherry-picked

  13. msullivan commented on May 31, 2018

    @msullivan
    CollaboratorAuthor

    Oh and #5053 should be probably done

  14. msullivan commented on Jun 1, 2018

    @msullivan
    CollaboratorAuthor

    OK since the pace of things that we need to cherry-pick has been continuing unabated all week, I am postponing the release another week so that we can validate it more.
    I plan to cherry-pick #5132 and #5126, and then we will hopefully have an actual "release candidate".
    (Though there will still be a documentation patch I need to write and cherry-pick.)

  15. msullivan commented on Jun 1, 2018

    @msullivan
    CollaboratorAuthor

    I believe that f3cb59a is now a release candidate.

  16. msullivan commented on Jun 6, 2018

    @msullivan
    CollaboratorAuthor

    Cherry picking the documentation patch #5157

  17. msullivan commented on Jun 7, 2018

    @msullivan
    CollaboratorAuthor

    Cherry picked the documentation patch #5164

  18. msullivan commented on Jun 8, 2018

    @msullivan
    CollaboratorAuthor

    Release out!

  19. timwraight commented on Jun 20, 2018

    @timwraight

    Just wanted to say what a massive difference 0.610 has made to my daily workflow. Having flycheck on emacs run dmypy run instead of mypy check is like night and day, and has made day to day coding so much more enjoyable. Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions