Bug with type: ignore comment on import and incremental

Still trying to get a test case. However, for now, I'll post the interesting parts:

In errors.py, I have code like this:

import colorama  # type: ignore

For some reason, the cache for this file at some point didn't add colorama to the suppressed section, so the import started being an error.

@Michael0x2a

Hm, interesting. @Michael0x2a might have some insights.

Create the following files:

x.py:
```
A = 0
from y import B
```

y.py:

import xyz  # type: ignore
B = 0
from x import A

Now, watch the following commands:

ryan@DevPC-LX ~/blaze-mypy/bug master $ mypy -i x.py  # Works.
ryan@DevPC-LX ~/blaze-mypy/bug master $ touch x.py    # Update the mtime of x.py.
ryan@DevPC-LX ~/blaze-mypy/bug master $ mypy -i x.py  # Works.
ryan@DevPC-LX ~/blaze-mypy/bug master $ touch x.py    # Update the mtime of x.py again.
ryan@DevPC-LX ~/blaze-mypy/bug master $ mypy -i x.py  # Fails!
x.py:2: note: In module imported here:
y.py:1: error: Cannot find module named 'xyz'
y.py:1: note: (Perhaps setting MYPYPATH or using the "--silent-imports" flag would help)
ryan@DevPC-LX ~/blaze-mypy/bug master $

Workaround to avoid having to clear the entire cache: rm .mypy_cache/*/y.*.json, replacing y with the module that had the type: ignore comment.

Workarounds for incremental mode that requires deleting cache files are not very useful. :-)

Well, I actually just realized that a much, much better workaround is to just do touch y.py... I don't know why I didn't think of that before...

But it definitely is a bug.

Is this still reproducible?

@gvanrossum

@gvanrossum Yup.

Fix python#2308: Keep suppressed imports in the suppressed list

Navigation Menu

Repository navigation

Bug with `type: ignore` comment on import and incremental #2308

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Bug with type: ignore comment on import and incremental #2308

Description

Activity

gvanrossum commented on Oct 24, 2016

refi64 commented on Oct 24, 2016

refi64 commented on Oct 24, 2016

gvanrossum commented on Oct 25, 2016

refi64 commented on Oct 25, 2016

gvanrossum commented on Oct 25, 2016

gvanrossum commented on Mar 24, 2017

refi64 commented on Mar 27, 2017

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Bug with `type: ignore` comment on import and incremental #2308