Regression with type narrowing of bool

@ethan-leba

Regression in 0.920 / 0.930 compared with 0.910.

from typing import Any

def func() -> Any:
    ...

var = func()
reveal_type(var)  # Any
assert isinstance(var, bool)
reveal_type(var)  # bool

if var:
    reveal_type(var)  # Literal[True]
    pass
reveal_type(var)  # Any -> should still be 'bool'!

The type should not be lost if it can't be narrowed to Literal[True] or Literal[False]. It's a side effect of #10389. The issue was already mentioned #10389 (comment) but hasn't been addressed yet.

/CC: @ethan-leba

Ok, looks like I was able to debug this problem. It is not really related to #10389, but this PR just made this problem visible. But, theoretically you can come up with other examples. Like:

from typing import Any

var: Any
reveal_type(var)  # N: Revealed type is "Any"
assert isinstance(var, bool) or isinstance(var, str)
reveal_type(var)  # N: Revealed type is "Union[builtins.bool, builtins.str]"

if isinstance(var, bool):
    reveal_type(var)  # N: Revealed type is "builtins.bool"

# Should be `Union[builtins.bool, builtins.str]`, but:
reveal_type(var)  # N: Revealed type is "Any"

What is the cause of this problem?

mypy/mypy/binder.py

Lines 232 to 237 in f96446c

    
           options = self.options_on_return.pop() 
        
           if can_skip: 
        
               options.insert(0, self.frames[-1]) 
        
           self.last_pop_changed = self.update_from_options(options)

When we use allow_jump, it ends up with two frame objects in self.options_on_return[index]
Each type in self.options_on_return[index] is only a part of the original type
So, when we run this check: if not all(is_same_type(type, cast(Type, t)) for t in resulting_values[1:]): it evaluates to True and Any is returned

I guess we should write proper type joiner for frame object. Two frames with Var(x): Literal[True] and Var(x): Literal[False] should be joined as Var(x): bool. The same with union types.

I have a related issue. Not sure if the same cause, though. In this code:

https://github.com/life4/deal/blob/48c6b1dbc51781f95ebba19c618f875ca9199ad4/deal/_runtime/_contracts.py#L67-L74

contracts variable should be inferred as Contracts after contracts = cls(func) but now it is Optional[Any].

Explicitly annotating cls doesn't help.
If I explicitly annotate contracts: Optional[Contracts], it stays that way, no type refinement is done by contracts = cls(func)
If I add an explicit assert contracts is not None, it also doesn't help, contracts stays Optional[Contracts].

In mypy 0.910 everything was fine. In pyright everything is also correctly inferred.

Fixed by #18138, which should be released with mypy v1.14.0

@sobolevn

Fixed by #18138, which should be released with mypy v1.14.0

Yes, it is. Opened #18272 to add the regression test from @sobolevn above to our test suite.

Add regression test for isinstance narrowing (#18272)

Navigation Menu

Repository navigation

Regression with type narrowing of bool #11839

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	options = self.options_on_return.pop()

	if can_skip:
	options.insert(0, self.frames[-1])

	self.last_pop_changed = self.update_from_options(options)

Regression with type narrowing of bool #11839

Description

Activity

sobolevn commented on Dec 25, 2021

orsinium commented on Dec 27, 2021

brianschubert commented on Dec 8, 2024

cdce8p commented on Dec 9, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions