Skip to content

Add support for JIT binaries #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 4 commits into from
Jun 28, 2025
Merged

Add support for JIT binaries #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c86955
Add support for JIT binaries
mdboom Jun 27, 2025
121e1f6
Update backend/scripts/populate_binaries.py
mdboom Jun 27, 2025
598302b
Add LLVM to the environment
mdboom Jun 27, 2025
232158f
Only install LLVM for JIT builds
mdboom Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ on:
description: 'Make flags for CPython build'
required: false
default: '-j'
llvm:
description: 'LLVM version to use'
required: false
default: '19'

jobs:
benchmark:
Expand Down Expand Up @@ -61,8 +65,13 @@ jobs:
# Install CPython dependencies using their script
cd cpython
sudo .github/workflows/posix-deps-apt.sh

# Install Memray dependencies

# Install JIT dependencies
if [ "${{ inputs.binary_id }}" = "jit" ]; then
sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh ${{ inputs.llvm }}
fi

# Install Memray dependencies
sudo apt-get install -y \
python3-dev \
libdebuginfod-dev \
Expand All @@ -73,6 +82,10 @@ jobs:
env:
MEMORY_TRACKER_TOKEN: ${{ secrets.MEMORY_TRACKER_TOKEN }}
run: |
if [ "${{ inputs.binary_id }}" = "jit" ]; then
export PATH="$(llvm-config-${{ inputs.llvm }} --bindir):$PATH"
fi

# Build command with conditional flags
CMD="memory-tracker benchmark '${{ github.event.inputs.commit_range }}'"
CMD="$CMD --repo-path ./cpython"
Expand Down
9 changes: 9 additions & 0 deletions backend/scripts/populate_binaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ def get_standard_binaries():
"icon": "search",
"display_order": 7,
},
{
"id": "jit",
"name": "JIT Build",
"flags": ["--enable-experimental-jit"],
"description": "Just-In-Time compilation enabled.",
"color": "#fc03df",
"icon": "zap",
Copy link
Member

@brandtbucher brandtbucher Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this icon supposed to be unique? Looks like both PGO and nogil are using the same zap icon.

Copy link
Member

@pablogsal pablogsal Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, is just the icon that is used when displayed here: https://memory.python.org/binaries

it can be changed later in the admin panel

"display_order": 8,
},
]


Expand Down