Skip to content

Document backport and cherry-pick labels #126

Closed

Description

@Mariatta

There should be a documentation explaining what to do with the labels needs backport to X.Y and cherry-pick for X.Y. Perhaps as a new section in committing.rst?

I think this is the current workflow: (as discussed in python/core-workflow#23)

  • Apply needs backport to X.Y label to the PR against master.
  • Once master PR is approved and merged, create the cherry-pick PR.
  • Remove needs backport to X.Y label from master PR
  • Apply the cherry-pick for X.Y to the cherry-pick PR.
  • Prefix the cherry-pick pr description with [X.Y]
  • Issue can be closed once all cherry-pick PRs have been merged.

Where X.Y is one of the maintenance branches, e.g. 2.7, 3.5, 3.6

Related question: Can I assume that the core developer who merged the master PR will do the backport?

Thanks :)

Activity

  1. berkerpeksag commented on Feb 21, 2017

    @berkerpeksag
    Member

    +1 from me. We probably need to wait for a bit to settle on the exact workflow before starting to document it.

    We could probably cover the GitHub part in http://cpython-devguide.readthedocs.io/committing.html#backporting-changes-to-python-3-6-or-older-version (or split it to two separate subsections?)

    Related question: Can I assume that the core developer who merged the master PR will do the backport?

    +1. This is also my assumption.

  2. added a commit that references this issue on Mar 17, 2017
  3. added a commit that references this issue on Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions