Repository navigation

[3.11] gh-96046: Initialize ht_cached_keys in PyType_Ready() (GH-96047) - #96164

Merged

miss-islington merged 1 commit into

python:3.11from

miss-islington:backport-53e6a9a-3.11

Aug 22, 2022

miss-islington commented Aug 22, 2022 •

edited by bedevere-bot

Loading

Contributor

(cherry picked from commit 53e6a9a)

Co-authored-by: Christian Heimes [email protected]

Issue: Crash in specialize_dict_access(): type->ht_cached_keys is NULL on a pybind11 type #96046


          pythongh-96046: Initialize ht_cached_keys in PyType_Ready() (pythonGH…

…-96047)

(cherry picked from commit 53e6a9a)

Co-authored-by: Christian Heimes <[email protected]>

miss-islington requested a review from markshannon as a code owner

August 22, 2022 05:24

miss-islington commented Aug 22, 2022

Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request

gh-96046: Initialize ht_cached_keys in PyType_Ready() #96047

Merged

miss-islington commented Aug 22, 2022

Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot added the awaiting review label

tiran added the 🔨 test-with-buildbots label

bedevere-bot commented Aug 22, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 9776890 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots label

tiran requested a review from pablogsal

August 22, 2022 05:24

miss-islington commented Aug 22, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

4 similar comments

miss-islington commented Aug 22, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

miss-islington commented Aug 22, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

miss-islington commented Aug 22, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

miss-islington commented Aug 22, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

markshannon approved these changes

View reviewed changes

markshannon left a comment

Member

Looks good

bedevere-bot added awaiting merge and removed awaiting review labels

miss-islington commented Aug 22, 2022

Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit 3ea0beb into python:3.11

bedevere-bot removed the awaiting merge label

miss-islington deleted the backport-53e6a9a-3.11 branch

August 22, 2022 09:13

rwgk added a commit to rwgk/pybind11_scons that referenced this pull request


          As used for retesting:

9168ad0

pybind/pybind11#4142 (comment)

main: python/cpython#96047
3.11: python/cpython#96164

miss-islington commented Aug 24, 2022

Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

miss-islington commented Aug 24, 2022

Contributor Author

Status check is done, and it's a success ✅ .

miss-islington commented Sep 8, 2022

Contributor Author

Status check is done, and it's a success ✅.

1 similar comment

miss-islington commented Sep 8, 2022

Contributor Author

Status check is done, and it's a success ✅.

miss-islington commented Sep 8, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

miss-islington commented Sep 8, 2022

Contributor Author

Status check is done, and it's a success ✅.

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

miss-islington commented Sep 9, 2022

Contributor Author

Status check is done, and it's a success ✅.

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

miss-islington commented Sep 9, 2022

Contributor Author

Status check is done, and it's a success ✅.

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

3 similar comments

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

miss-islington commented Sep 9, 2022

Contributor Author

@tiran: Status check is done, and it's a failure ❌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet