Skip to content

gh-80480: Emit DeprecationWarning for array's 'u' type code - #95760

Merged
hugovk merged 14 commits into
python:mainfrom
hugovk:80480-deprecate-array-u
Jun 11, 2023
Merged

gh-80480: Emit DeprecationWarning for array's 'u' type code#95760
hugovk merged 14 commits into
python:mainfrom
hugovk:80480-deprecate-array-u

Conversation

@hugovk

@hugovk hugovk commented Aug 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The "u" type code for array was deprecated in Python 3.3 but only via documentation: https://docs.python.org/3.10/library/array.html

Let's add the DeprecationWarning.

It was originally planned to be removed in Python 4.0, but that was before we knew if 3.10 or 4.0 would come after 3.9:

'4.0' is a stand-in for 'sometime after 2.7.final', scheduled for Jan 2020.

#80480 (comment)

So as this is going into 3.12 3.13, let's target 3.14 3.15 3.16 for removal.

@hugovk hugovk mentioned this pull request Aug 7, 2022
Closed
@hugovk hugovk added the stdlib Standard Library Python modules in the Lib/ directory label Aug 7, 2022
ezio-melotti
ezio-melotti reviewed Aug 11, 2022
View reviewed changes
Comment thread Lib/test/test_array.py Outdated
@asedeno

asedeno commented Aug 30, 2022

Copy link
Copy Markdown

As a user of the 'u' array type, I'd like to see this postponed until a UCS4 'w' array type is in place to migrate to, as was proposed in #80480 (comment).

@smontanaro

smontanaro commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.)

Looks like this was approved before @asedeno's comment. Can someone respond to the expressed concern? (It seems no 'w' code has been implemented yet.)

@hugovk

hugovk commented Nov 27, 2022

Copy link
Copy Markdown
Member Author

Thanks for the ping. I commented in the issue, let's continue there.

@hauntsaninja
hauntsaninja marked this pull request as draft December 23, 2022 05:46
@arhadthedev arhadthedev added extension-modules C modules in the Modules dir and removed stdlib Standard Library Python modules in the Lib/ directory labels May 5, 2023
@hugovk

hugovk commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

Updated to target removal in 3.16, following addition of 'w' in #105242 and following the plan at #80480 (comment).

@hugovk
hugovk marked this pull request as ready for review June 4, 2023 18:01
methane
methane reviewed Jun 5, 2023
View reviewed changes
Comment thread Lib/test/test_re.py Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.13.rst Outdated
vstinner
vstinner reviewed Jun 6, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst
Comment thread Modules/arraymodule.c Outdated
vstinner
vstinner reviewed Jun 6, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Lib/test/test_buffer.py
vstinner
vstinner approved these changes Jun 6, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left minor remarks on the doc. It's up to you to address them or ignore them ;-) Thanks for the updates.

Comment thread Doc/whatsnew/3.13.rst
@hugovk
hugovk merged commit cc87948 into python:main Jun 11, 2023
@hugovk
hugovk deleted the 80480-deprecate-array-u branch June 11, 2023 09:17
@arhadthedev arhadthedev mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@ezio-melotti ezio-melotti ezio-melotti left review comments
@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

extension-modules C modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hugovk @asedeno @smontanaro @vstinner @methane @ezio-melotti @arhadthedev @bedevere-bot