bpo-29950: Rename SlotWrapperType to WrapperDescriptorType#926
Merged
berkerpeksag merged 1 commit intopython:masterfrom Apr 25, 2017
DimitrisJim:issue29950
Merged
bpo-29950: Rename SlotWrapperType to WrapperDescriptorType#926berkerpeksag merged 1 commit intopython:masterfrom DimitrisJim:issue29950
berkerpeksag merged 1 commit intopython:masterfrom
DimitrisJim:issue29950
Conversation
|
@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ethanfurman, @1st1 and @ericvsmith to be potential reviewers. |
Member
|
This PR may break |
Contributor
Author
|
@ilevkivskyi Yes, I was planning on doing that. I'll open a PR shortly. |
Member
|
I just merged the typing PR, I think this PR could be merged as well. |
DimitrisJim
changed the title
berkerpeksag
approved these changes
Apr 25, 2017
Member
|
Oops, sorry I missed the typo in the commit message. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name
SlotWrapperTypewas added in bpo-29377 but it added the type based on the repr of the object instead of it's type astype(object.__init__)results in. PR changes this toWrapperDescriptorTypeto avoid and any unecessary confusion down the line.