Skip to content

bpo-8145: Improve isolation_level documentation#8499

Merged
zooba merged 1 commit intopython:masterfrom
berkerpeksag:8145-sqlite-isolation-level
Jul 29, 2018
Merged

bpo-8145: Improve isolation_level documentation#8499
zooba merged 1 commit intopython:masterfrom
berkerpeksag:8145-sqlite-isolation-level

Conversation

@berkerpeksag
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag commented Jul 27, 2018 •
edited by bedevere-bot
Loading

Initial patch by R. David Murray.

https://bugs.python.org/issue8145

@berkerpeksag
bpo-8145: Improve isolation_level documentation
a06f98b 
Initial patch by R. David Murray.
@berkerpeksag berkerpeksag requested a review from bitdancer July 27, 2018 10:26
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Jul 27, 2018
@zooba zooba merged commit a71fed0 into python:master Jul 29, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 29, 2018

Thanks @berkerpeksag for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 29, 2018

Sorry @berkerpeksag and @zooba, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a71fed0b7596f1c11a2fa6c1b7311157148f5f9f 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2018
@berkerpeksag @miss-islington
bpo-8145: Improve isolation_level documentation (pythonGH-8499)
55ec961 
Initial patch by R. David Murray.
(cherry picked from commit a71fed0)

Co-authored-by: Berker Peksag <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 29, 2018

GH-8539 is a backport of this pull request to the 3.6 branch.

@zooba
Copy link
Copy Markdown
Member

zooba commented Jul 29, 2018

@Mariatta - what does the error from miss-islington mean? Is this something that needs fixing on her server?

zooba pushed a commit that referenced this pull request Jul 29, 2018
@miss-islington @berkerpeksag @zooba
bpo-8145: Improve isolation_level documentation (GH-8499)
94972d5 
Initial patch by R. David Murray.
(cherry picked from commit a71fed0)

Co-authored-by: Berker Peksag <[email protected]>
zooba pushed a commit to zooba/cpython that referenced this pull request Jul 29, 2018
@berkerpeksag @zooba
bpo-8145: Improve isolation_level documentation (pythonGH-8499)
a877a39 
Initial patch by R. David Murray.
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 29, 2018

GH-8543 is a backport of this pull request to the 3.7 branch.

@berkerpeksag berkerpeksag deleted the 8145-sqlite-isolation-level branch July 29, 2018 09:21
zooba added a commit that referenced this pull request Jul 29, 2018
@zooba
bpo-8145: Improve isolation_level documentation (GH-8499)
3dc8cdf 
Initial patch by R. David Murray.
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Jul 29, 2018

Seems like it was trying to do two backports at the same time in the same git repo, so the second one errored out.

Thought I had a mechanism to prevent this from happening, but will look into it again.
A workaround is to reapply the needs backport label after the first backport PR has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees

@zooba zooba

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@berkerpeksag @miss-islington @bedevere-bot @zooba @Mariatta @the-knights-who-say-ni