Skip to content

bpo-34230: Fix crashes in pysqlite_build_row_cast_map() on memory allocation failure. #8473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sir-sigurd wants to merge 1 commit into from
Closed

bpo-34230: Fix crashes in pysqlite_build_row_cast_map() on memory allocation failure. #8473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2018-07-26-10-38-57.bpo-34230.aSUdKF.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix crashes in :mod:`sqlite3` on memory allocation failure. Patch by Sergey
Fedoseev.
6 changes: 3 additions & 3 deletions Modules/_sqlite/cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ int pysqlite_build_row_cast_map(pysqlite_Cursor* self)
}

Py_XSETREF(self->row_cast_map, PyList_New(0));
if (!self->row_cast_map) {
return -1;
}

for (i = 0; i < sqlite3_column_count(self->statement->st); i++) {
converter = NULL;
Expand Down Expand Up @@ -186,9 +189,6 @@ int pysqlite_build_row_cast_map(pysqlite_Cursor* self)
}

if (PyList_Append(self->row_cast_map, converter) != 0) {
if (converter != Py_None) {
Py_DECREF(converter);
}
Py_CLEAR(self->row_cast_map);

return -1;
Expand Down